Support not updating Items and HeaderFooters at all if they are equivalent #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably will close this out; once https://github.com/square/Blueprint/pull/239/files lands; this is mostly not useful. |
kyleve
commented
Jul 31, 2021
kyleve
force-pushed
the
kve/support-not-updating-items-if-equiv
branch
from
ecb6608
to
48499b9
Compare
…ing-items-if-equiv * origin/main: (26 commits) Prepare 0.23.1 Fix crash in prepare() because isReordering is set even during scroll invalidations. Queue changes while reorder events are settling; so that mutative updates after the edit do not cause crashes within UICollectionView; it does not account for mutations while a reorder is settling. Update docs Prep 0.23.0 Add support for setting default HeaderFooter properties via HeaderFooterContent's defaultHeaderFooterProperties. Add anyContent on HeaderFooter to match Item. Fix changelog reference for 0.22.2 (#301) 0.22.2 (#300) Update docs Fix Identifiable conformance in ItemContent. Bump Blueprint and release 0.22.0 (#298) Update changelog Update docs Update 0.21.0 version numbers. Log a warning when reordering during updates. Fix animations when applying updates to visible cells. Fix Xcode 12 build error when creating inline Blueprint items. Demo: Payment types reordering Support re-ordering between sections. Add additional validation and reading options for re-order events. Improve Identifier to aid in type safety when creating and reading identifiers. See #292 for all changes and discussion. Remove spaces from filepaths ...
kyleve
changed the title
kyleve
commented
Aug 3, 2021
kyleve
commented
Aug 3, 2021
kyleve
commented
Aug 7, 2021
ListableUI/Sources/Internal/PresentationState/PresentationState.HeaderFooterState.swift
Outdated
Show resolved
Hide resolved
kyleve
commented
Aug 8, 2021
…ing-items-if-equiv * origin/main: Prep 0.23.2 enable horizontal scroll actions.
…OS implementation Equatable wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
ItemContentandHeaderFooterContentto support not updating their on-screen content if they are equivalent. This is done by introducingReappliesToVisibleView, with the option.alwaysand.ifNotEquivalent.