Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow controlling the layout bounds via the Environment #317

Merged
merged 1 commit into from Aug 15, 2021

Conversation

kyleve
Copy link
Collaborator

@kyleve kyleve commented Aug 14, 2021

This PR does a couple things:

  • Splits the padding and width constraint out into its own type, ListContentBounds, which can be shared across layouts; and now have a default provided by the environment. This will eventually allow Market to provide a default content bounds to implement its desired sizing and padding behaviour.
  • Renamed ListSizing to List.Measurement, to reflect that it is only used by List, and to better match the Blueprint terminology for measurement.

@kyleve kyleve force-pushed the kve/allow-env-to-control-layout-bounds branch 3 times, most recently from 1e4ff46 to da2f888 Compare August 14, 2021 23:47
@kyleve kyleve enabled auto-merge August 14, 2021 23:54
@kyleve kyleve force-pushed the kve/allow-env-to-control-layout-bounds branch from da2f888 to 322952b Compare August 15, 2021 00:01
@kyleve kyleve merged commit c07a6ae into main Aug 15, 2021
@kyleve kyleve deleted the kve/allow-env-to-control-layout-bounds branch August 15, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant