Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmartPost Support? #37

Closed
cjones-swarm opened this issue Jan 11, 2016 · 10 comments
Closed

SmartPost Support? #37

cjones-swarm opened this issue Jan 11, 2016 · 10 comments

Comments

@cjones-swarm
Copy link

How do I go about implementing Fedex SmartPost HubID and Indicia Type w/ the GetRates call and having SmartPost returned as a rate type?

@kylewest
Copy link
Owner

Hi Charles,

I hadn't heard of SmartPost before your post. I managed to find the marketing materials on the FedEx site but none of the developer documentation. Do you have links to those docs?

This isn't something I will be able to tackle in the near future but I'm happy to help you figure it out and submit a pull request. The work most likely involves setting/changing some parameters in the FedExProvider but if the request/response is dramatically different you may need to create a SmartPostProvider.

Kyle

@StephenPAdams
Copy link
Contributor

I might have to end up adding this feature to DotNetShipping per a client's requirements. If so, I'll submit a pull request once created.

@kylewest
Copy link
Owner

Awesome. Would appreciate that!

kyle

@StephenPAdams
Copy link
Contributor

@cjones-swarm and @kylewest I have something working on my fork. Essentially I ended up creating a new FedEx SmartPost provider because there were enough nuances between the current FedEx rate lookup and the SmartPost rate lookup request that I thought it'd be better to separate them. If you want to give it a preliminary look, it's located here: https://github.com/StephenPAdams/DotNetShipping

Unfortunately I wasn't following best practices, so my fork is out of date from yours, @kylewest . So I'll do some finagling to get this so I can get a clean pull request your way later this week. Thoughts?

@StephenPAdams
Copy link
Contributor

And pull request created :)
#51

Hopefully this works for your use cases!

@kylewest
Copy link
Owner

closed by #51

@StephenPAdams
Copy link
Contributor

Awesome! Thanks @kylewest :) Love this library.

@kylewest
Copy link
Owner

no problem @StephenPAdams ... you did all the work. BTW, added you to the credits. when I was doing so noticed you are in Baltimore. shoot me an email sometime, I'm just outside DC in MD.

@StephenPAdams
Copy link
Contributor

Very cool! Definitely. Although I don't have your email addy @kylewest ! One of GitHub's quirky nature is not being able to DM.

@kylewest
Copy link
Owner

click @kylewest .. it's in there 👍

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants