Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Cross-Site Scripting Vulnerability #57

Open
tch1bo opened this issue Nov 17, 2018 · 0 comments
Open

Possible Cross-Site Scripting Vulnerability #57

tch1bo opened this issue Nov 17, 2018 · 0 comments

Comments

@tch1bo
Copy link

tch1bo commented Nov 17, 2018

Hey,

I noticed a possible XSS (https://www.owasp.org/index.php/Cross-site_Scripting_(XSS)) vulnerability in line:

resp = make_response("Could not find a service for URL {}"

Unsanitized user input gets into flask.make_response() and then into user's browser. This opens a possibility for the attacker to supply input like "<script>some_code</script>" and execute arbitrary code in user's browser.

I'm not sure how your application is meant to be deployed, but if an attacker may trick an honest user to access "your_site.com/indieauth?redirect_uri=foo&me=attack_vector", then this is a security risk and you should consider fixing it.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant