-
Notifications
You must be signed in to change notification settings - Fork 85
/
generic_repo_get_tests.go
192 lines (160 loc) · 6.63 KB
/
generic_repo_get_tests.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
package testdb
import (
"context"
"fmt"
"reflect"
"testing"
"github.com/kyma-incubator/compass/components/director/pkg/apperrors"
"github.com/kyma-incubator/compass/components/director/pkg/persistence"
"github.com/pkg/errors"
"github.com/stretchr/testify/require"
)
// RepoGetTestSuite represents a generic test suite for repository Get method of any global entity or entity that has externally managed tenants in m2m table/view.
// This test suite is not suitable entities with embedded tenant in them.
type RepoGetTestSuite struct {
Name string
SQLQueryDetails []SQLQueryDetails
ConverterMockProvider func() Mock
RepoConstructorFunc interface{}
ExpectedModelEntity interface{}
ExpectedDBEntity interface{}
MethodArgs []interface{}
AdditionalConverterArgs []interface{}
DisableConverterErrorTest bool
MethodName string
ExpectNotFoundError bool
AfterNotFoundErrorSQLQueryDetails []SQLQueryDetails
AfterNotFoundErrorExpectedModelEntity interface{}
AfterNotFoundErrorExpectedDBEntity interface{}
}
// Run runs the generic repo get test suite
func (suite *RepoGetTestSuite) Run(t *testing.T) bool {
if len(suite.MethodName) == 0 {
suite.MethodName = "GetByID"
}
for _, queryDetails := range suite.SQLQueryDetails {
if !queryDetails.IsSelect {
panic("get suite should expect only select SQL statements")
}
}
return t.Run(suite.Name, func(t *testing.T) {
testErr := errors.New("test error")
t.Run("success", func(t *testing.T) {
sqlxDB, sqlMock := MockDatabase(t)
ctx := persistence.SaveToContext(context.TODO(), sqlxDB)
configureValidSQLQueries(sqlMock, suite.SQLQueryDetails)
convMock := suite.ConverterMockProvider()
convMock.On("FromEntity", append([]interface{}{suite.ExpectedDBEntity}, suite.AdditionalConverterArgs...)...).Return(suite.ExpectedModelEntity, nil).Once()
pgRepository := createRepo(suite.RepoConstructorFunc, convMock)
// WHEN
res, err := callGet(pgRepository, ctx, suite.MethodName, suite.MethodArgs)
// THEN
require.NoError(t, err)
require.Equal(t, suite.ExpectedModelEntity, res)
sqlMock.AssertExpectations(t)
convMock.AssertExpectations(t)
})
t.Run("returns not found error when no rows", func(t *testing.T) {
sqlxDB, sqlMock := MockDatabase(t)
ctx := persistence.SaveToContext(context.TODO(), sqlxDB)
configureInvalidSelect(sqlMock, suite.SQLQueryDetails)
convMock := suite.ConverterMockProvider()
if suite.ExpectNotFoundError {
convMock.On("FromEntity", append([]interface{}{suite.AfterNotFoundErrorExpectedDBEntity}, suite.AdditionalConverterArgs...)...).Return(suite.AfterNotFoundErrorExpectedModelEntity, nil).Once()
configureValidSQLQueries(sqlMock, suite.AfterNotFoundErrorSQLQueryDetails)
}
pgRepository := createRepo(suite.RepoConstructorFunc, convMock)
// WHEN
res, err := callGet(pgRepository, ctx, suite.MethodName, suite.MethodArgs)
// THEN
if !suite.ExpectNotFoundError {
require.Error(t, err)
require.Equal(t, apperrors.NotFound, apperrors.ErrorCode(err))
require.Contains(t, err.Error(), apperrors.NotFoundMsg)
require.Nil(t, res)
sqlMock.AssertExpectations(t)
convMock.AssertExpectations(t)
} else {
require.NoError(t, err)
require.Equal(t, suite.AfterNotFoundErrorExpectedModelEntity, res)
sqlMock.AssertExpectations(t)
convMock.AssertExpectations(t)
}
})
for i := range suite.SQLQueryDetails {
t.Run(fmt.Sprintf("error if SQL query %d fail", i), func(t *testing.T) {
sqlxDB, sqlMock := MockDatabase(t)
ctx := persistence.SaveToContext(context.TODO(), sqlxDB)
configureFailureForSQLQueryOnIndex(sqlMock, suite.SQLQueryDetails, i, testErr)
convMock := suite.ConverterMockProvider()
pgRepository := createRepo(suite.RepoConstructorFunc, convMock)
// WHEN
res, err := callGet(pgRepository, ctx, suite.MethodName, suite.MethodArgs)
// THEN
require.Nil(t, res)
require.Error(t, err)
require.Equal(t, apperrors.InternalError, apperrors.ErrorCode(err))
require.Contains(t, err.Error(), "Internal Server Error: Unexpected error while executing SQL query")
sqlMock.AssertExpectations(t)
convMock.AssertExpectations(t)
})
}
if suite.ExpectNotFoundError {
t.Run("error if SQL query fail", func(t *testing.T) {
sqlxDB, sqlMock := MockDatabase(t)
ctx := persistence.SaveToContext(context.TODO(), sqlxDB)
configureInvalidSelect(sqlMock, suite.SQLQueryDetails)
convMock := suite.ConverterMockProvider()
configureFailureForSQLQueryOnIndex(sqlMock, suite.AfterNotFoundErrorSQLQueryDetails, 0, testErr)
pgRepository := createRepo(suite.RepoConstructorFunc, convMock)
// WHEN
res, err := callGet(pgRepository, ctx, suite.MethodName, suite.MethodArgs)
// THEN
require.Nil(t, res)
require.Error(t, err)
require.Equal(t, apperrors.InternalError, apperrors.ErrorCode(err))
require.Contains(t, err.Error(), "Internal Server Error: Unexpected error while executing SQL query")
sqlMock.AssertExpectations(t)
convMock.AssertExpectations(t)
})
}
if !suite.DisableConverterErrorTest {
t.Run("error when conversion fail", func(t *testing.T) {
sqlxDB, sqlMock := MockDatabase(t)
ctx := persistence.SaveToContext(context.TODO(), sqlxDB)
configureValidSQLQueries(sqlMock, suite.SQLQueryDetails)
convMock := suite.ConverterMockProvider()
convMock.On("FromEntity", append([]interface{}{suite.ExpectedDBEntity}, suite.AdditionalConverterArgs...)...).Return(nil, testErr).Once()
pgRepository := createRepo(suite.RepoConstructorFunc, convMock)
// WHEN
res, err := callGet(pgRepository, ctx, suite.MethodName, suite.MethodArgs)
// THEN
require.Nil(t, res)
require.Error(t, err)
require.Contains(t, err.Error(), testErr.Error())
sqlMock.AssertExpectations(t)
convMock.AssertExpectations(t)
})
}
})
}
func callGet(repo interface{}, ctx context.Context, methodName string, args []interface{}) (interface{}, error) {
argsVals := make([]reflect.Value, 1, len(args))
argsVals[0] = reflect.ValueOf(ctx)
for _, arg := range args {
argsVals = append(argsVals, reflect.ValueOf(arg))
}
results := reflect.ValueOf(repo).MethodByName(methodName).Call(argsVals)
if len(results) != 2 {
panic("Get should return two argument")
}
errResult := results[1].Interface()
if errResult == nil {
return results[0].Interface(), nil
}
err, ok := errResult.(error)
if !ok {
panic("Expected result to be an error")
}
return results[0].Interface(), err
}