Skip to content
This repository has been archived by the owner on Oct 27, 2022. It is now read-only.

Implement Before and BeforeAll logic execution #34

Closed
polskikiel opened this issue Sep 13, 2019 · 4 comments
Closed

Implement Before and BeforeAll logic execution #34

polskikiel opened this issue Sep 13, 2019 · 4 comments
Labels
area/quality Related to all activites around quality kind/feature Categorizes issue or PR as related to a new feature. wontfix This will not be worked on

Comments

@polskikiel
Copy link
Contributor

Description

In Kyma we have some issues with the execution of our tests which applies to every test pod.

  1. When we start a test we always need to add a testing-addons to our cluster otherwise, the tests will fail. The number of required things for our tests can increase in time, so it's better to implement it here rather than in many different places later, which will be much harder to maintenance.

  2. All of our test pods contain a sidecar which blocks Pod's connections to API server until sidecar is ready. It may fail tests if they don't have a waiter.

Above issues can be addressed in Octopus by implementing a proper logic which will be executed once before test suite execution AND a logic which will be executed before each test.

It should be configurable from the TestSuite level.

Reasons

Many tests have common issues. This implementation allows us to avoid many issues and boilerplate code in the future.

Attachments

@polskikiel polskikiel added kind/feature Categorizes issue or PR as related to a new feature. quality/testability labels Sep 13, 2019
@aszecowka aszecowka added area/quality Related to all activites around quality WIP and removed quality/testability labels Oct 22, 2019
@stale
Copy link

stale bot commented Oct 24, 2020

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 24, 2020
@k15r
Copy link

k15r commented Oct 29, 2020

Octopus already supports executing Testdefinitions based on labels. An easy solution to the 'before' case that would not require any change on octopus would be to specify a label e.g. kyma-project.io/test.integration-setup=true and kyma-project.io/test.integration-teardown=true

Using those labels would then just be a change in the integration-test scripts. Currently a similar mechanic is used in the upgrade tests. Here we use kyma-project.io/test.before-upgrade to prepare the cluster.

@stale stale bot removed the stale label Oct 29, 2020
@stale
Copy link

stale bot commented Jan 11, 2021

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 11, 2021
@lilitgh lilitgh removed the stale label Jan 19, 2021
@stale stale bot removed the stale label Jan 19, 2021
@lilitgh lilitgh added stale and removed WIP labels Jan 19, 2021
@stale stale bot removed the stale label Jan 19, 2021
@pbochynski
Copy link

We will not work on it.

@pbochynski pbochynski added the wontfix This will not be worked on label Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/quality Related to all activites around quality kind/feature Categorizes issue or PR as related to a new feature. wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

5 participants