Skip to content
This repository has been archived by the owner on Oct 27, 2022. It is now read-only.

Add automatic tests #55

Closed
pzamzow opened this issue Feb 7, 2020 · 2 comments
Closed

Add automatic tests #55

pzamzow opened this issue Feb 7, 2020 · 2 comments
Assignees
Labels
area/cli Related to all activities around CLI

Comments

@pzamzow
Copy link
Contributor

pzamzow commented Feb 7, 2020

Description
At the moment the provider does not have any automatic unit or acceptance tests. Terraform has a build-in testing framework, which should be adopted to keep the provider stable in the future. As a first step unit tests should be sufficient. But in the end automatic acceptance tests, which create real infrastructure during the tests, should prevent regressions.

When the automatic tests are executed, the code coverage should be measured and checked. GO has support for this build-in (see here). Unfortunately the current package structure would not allow an accurate coverage result, because GO tools are not working well with multiple packages (issue is described here). Therefore the tool mentioned in the article needs to be used or the package structure needs be adopted. In the end the CI infrastructure should not allow new code, which is not covered by a test.

@a-thaler a-thaler added the area/cli Related to all activities around CLI label Feb 7, 2020
@a-thaler a-thaler added this to the Backlog_Huskies milestone Feb 7, 2020
@clebs
Copy link
Contributor

clebs commented Feb 25, 2020

Hi @pzamzow,
thanks for reporting this issue. It is true that there is a lack of tests in this provider and we definitely must add them soon.
The idea you propose using the terraform testing framework to do infrastructure tests would be great together with the unit tests.

Regarding the coverage, we are already measuring test coverage on other Go repos we have (for example https://github.com/kyma-project/cli) also based on the article you mention. We would add that coverage as well as soon as there are tests on this repo.

We will add this issue to our backlog, keep track of it and work on it as soon as possible.

@a-thaler a-thaler removed this from the Backlog_Huskies milestone May 25, 2020
@a-thaler a-thaler self-assigned this May 25, 2020
@a-thaler
Copy link
Collaborator

We plan to not continue the project, see #83

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli Related to all activities around CLI
Projects
None yet
Development

No branches or pull requests

3 participants