Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt to latest changes in uninstallation #111

Closed
a-thaler opened this issue Jun 7, 2019 · 1 comment
Closed

Adopt to latest changes in uninstallation #111

a-thaler opened this issue Jun 7, 2019 · 1 comment
Assignees
Labels
area/cli Related to all activities around CLI

Comments

@a-thaler
Copy link
Contributor

a-thaler commented Jun 7, 2019

Description
The Kyma Installer will be improved for the uninstallation action, see kyma-project/kyma#2942. Assure that "kyma uninstall" command will work with that changes

Reasons
Assure working software

@a-thaler a-thaler added the area/cli Related to all activities around CLI label Jun 7, 2019
@a-thaler a-thaler added this to the Backlog_Huskies milestone Jun 7, 2019
@a-thaler a-thaler modified the milestones: Backlog_Huskies, Sprint_Huskies_4 Jun 21, 2019
@clebs clebs self-assigned this Jul 2, 2019
@clebs
Copy link
Contributor

clebs commented Jul 2, 2019

Discussed the uninstall changes:

  • Now all errors are all logged into the installer's errorLog
  • Now the uninstallation is retried indefinitely until it succeeds (infinite loop if a component always fails).

Based on that information, the changes proposed for the CLI are:

  • Introduce a default timeout for the uninstall command. Now a timeout is always required, otherwise the CLI could enter an infinite loop too.
  • Adapt the error status messages printed by the CLI when a component fails to uninstall to reflect the new retry nature of the process.
  • Error log will be printed at the end of the timeout as before, it will now usually contain all errors throughout the process, not only the last one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to all activities around CLI
Projects
None yet
Development

No branches or pull requests

2 participants