Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable passing a list of modules to enable module and disable module commands #1639

Closed
3 tasks
janmedrek opened this issue Apr 20, 2023 · 2 comments
Closed
3 tasks

Comments

@janmedrek
Copy link
Contributor

janmedrek commented Apr 20, 2023

Description

The enable module and disable module commands should be extended to accept a list of modules to enable multiple modules at once.

Reasons

The commands only enable/disable a single module at a time. This can be time-consuming when there are multiple modules to enable. Enabling/disabling multiple modules at once can save time and effort.

Acceptance Criteria

  • Commands accept lists of modules
  • E2E test for the feature implemented
    • duplicates of template-operator are enabled/disabled
    • check if the list of modules was correctly adjusted (Kyma doesn't need to go into Ready state)
  • Log the follow-up issue for the validation logic of the passed list

Blocked By
kyma-project/template-operator#98

@janmedrek janmedrek changed the title Allow for passing a list of modules to enable module command Enable passing a list of modules to enable module command Apr 20, 2023
@kyma-bot
Copy link

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 19, 2023
@janmedrek janmedrek removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 21, 2023
@kyma-bot
Copy link

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 20, 2023
@janmedrek janmedrek removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 24, 2023
@janmedrek janmedrek changed the title Enable passing a list of modules to enable module command Enable passing a list of modules to enable module and disable module commands Oct 5, 2023
@janmedrek janmedrek closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants