Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istio operator installs kyma istio-resources #334

Closed
17 tasks done
strekm opened this issue Aug 24, 2023 · 0 comments
Closed
17 tasks done

Istio operator installs kyma istio-resources #334

strekm opened this issue Aug 24, 2023 · 0 comments
Assignees
Labels
area/service-mesh Issues or PRs related to service-mesh kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@strekm
Copy link
Collaborator

strekm commented Aug 24, 2023

Description

Enhance istio operator reconcile loop with installation on Istio related resources that are part of kyma istio resources component. Make sure that this implementation is not clashing with helm reconciler in migration period. Once this implementation is rolled out to all envs and it is not part of kyma components list, istio-resources will be deleted.

Consider applying default kyma gateway as a part of istio operator for short period of time to be able to delete istio-resources component from kyma. Later on kyma default gateway and kyma default domain will be completely moved to api-gateway operator (module). Have in mind: kyma-project/kyma#17616

There's no need to enhance Istio API.

ACs:

  • Istio operator installs istio resources
  • istio operator and helm reconciler are not conflicting over istio resources
  • istio resources are labeled as managed by istio operator
  • any manual changes done to installed resources are reconciled to default settings
  • documentation created
  • integration test created / updated

Reasons

modularisation of kyma components

Open questions

  • Do we need monitoring / dashboards configurable? - For now we apply always, no configuration.
  • Do we need to restart IGW or Proxies on any changes of istio-resources ? -> follow-up task created for this in Backlog
  • Both Reconciler and Istio Operator will apply resources, but in the end definition would be almost the same. - Should be okay for the time being.

DoD:

  • provide documentation
  • release notes and What's New updates for Kyma customers
  • provide unit tests
  • provide integration tests
  • test on production-like environment
  • verify resource limits
    - [ ] followup issue
  • PR reviewer will verify code coverage and evaluate if it is acceptable

PRs

Attachments

https://github.com/kyma-project/kyma/tree/main/resources/istio-resources

@strekm strekm added kind/feature Categorizes issue or PR as related to a new feature. area/service-mesh Issues or PRs related to service-mesh labels Aug 24, 2023
@strekm strekm added this to the 1.1 milestone Aug 24, 2023
@videlov videlov self-assigned this Aug 28, 2023
@videlov videlov assigned barchw and unassigned videlov Aug 31, 2023
@strekm strekm closed this as completed Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/service-mesh Issues or PRs related to service-mesh kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants