Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local run mode to eventing-controller #11422

Closed
themue opened this issue Jun 4, 2021 · 3 comments
Closed

Fix local run mode to eventing-controller #11422

themue opened this issue Jun 4, 2021 · 3 comments
Assignees
Labels
area/eventing Issues or PRs related to eventing kind/bug Categorizes issue or PR as related to a bug.

Comments

@themue
Copy link
Contributor

themue commented Jun 4, 2021

Description

Changes in #11404 showed that local running of the eventing controller doesn't work anymore. Beside setting environment variables the controller had to react at runtime.

Expected result

When the eventing-controller runs on the dev machine, the event-publisher-proxies ownerref should be either ignored or set to a junk value, so that the functionality doesn't break.

Actual result

Error log tells that deployment cannot be found.

Steps to reproduce

$ k port-forward -n kyma-system svc/eventing-nats 4222
$ make run
@themue themue added kind/bug Categorizes issue or PR as related to a bug. area/eventing Issues or PRs related to eventing labels Jun 4, 2021
@kyma-stale-bot
Copy link

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

@kyma-stale-bot kyma-stale-bot bot added the stale label Aug 22, 2021
@sayanh sayanh removed the stale label Aug 26, 2021
@pxsalehi
Copy link
Contributor

pxsalehi commented Oct 5, 2021

The issue is from here where the eventing-controller tries to "look itself up" in the cluster.

One solution could be to move out the setAsOwnerReference out into a separate file, and use build tags (e.g. debug and !debug) to replace the implementation with a dummy one. This way a local make target with the right tag could be used to run the controller in the IDE.

@k15r k15r removed their assignment Oct 11, 2021
@sayanh sayanh self-assigned this Oct 20, 2021
@k15r
Copy link
Contributor

k15r commented Oct 26, 2021

fixed by #12307

@k15r k15r closed this as completed Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants