Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a health check endpoint to the api-gateway-controller #11726

Closed
skhalash opened this issue Jul 21, 2021 · 1 comment · Fixed by #11730
Closed

Add a health check endpoint to the api-gateway-controller #11726

skhalash opened this issue Jul 21, 2021 · 1 comment · Fixed by #11730
Assignees
Labels
area/api-gateway Issues or PRs related to api-gateway kind/feature Categorizes issue or PR as related to a new feature.

Comments

@skhalash
Copy link
Contributor

Description

Add a health check endpoint to the api-gateway-controller.

Reasons

A new way of monitoring Kyma runtime availability requires readiness probes to be configured for all workloads (deployments, stateful sets, daemon sets). When assessing Kyma components we realised that most of the self-written controllers/operators are missing health endpoints (which could be used as readiness probes).

As a temporary workaround we decided to abuse the /metrics endpoint for this purpose. But in the future it would useful to have a native health check endpoint.

Attachments

Here's an example from the nats operator which we could draw inspiration from.

@skhalash skhalash added the area/api-gateway Issues or PRs related to api-gateway label Jul 21, 2021
@skhalash skhalash added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 21, 2021
@skhalash skhalash linked a pull request Jul 22, 2021 that will close this issue
@skhalash
Copy link
Contributor Author

As I wrote above #11730 is a temporary solution and should be replaced by a real health check endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api-gateway Issues or PRs related to api-gateway kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants