Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default scale config preset #15291

Closed
dbadura opened this issue Aug 25, 2022 · 1 comment
Closed

Remove default scale config preset #15291

dbadura opened this issue Aug 25, 2022 · 1 comment
Labels
area/serverless Issues or PRs related to serverless duplicate This issue or pull request already exists

Comments

@dbadura
Copy link
Contributor

dbadura commented Aug 25, 2022

Description
In function CR there are two fields connected with replicas:

  • scaleConfig
  • replicas

Serverless has default scale config preset which is not needed because if user decide to use scaleConfig, the min/max field are required to be set.
Additionally the replicas field should be the default configuration about replicas

Reasons

In v1alpha2 the min/max values in scaleConfig are required, so the default scale config preset is not needed and it should be deleted

Attachments
@dbadura dbadura added the area/serverless Issues or PRs related to serverless label Aug 25, 2022
@kwiatekus kwiatekus mentioned this issue Sep 2, 2022
Closed
@kwiatekus
Copy link
Contributor

Closing in favor of #14900

@kwiatekus kwiatekus added the duplicate This issue or pull request already exists label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/serverless Issues or PRs related to serverless duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kwiatekus @dbadura