Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH backend should be classes and not namedtuple #452

Closed
edouardoyallon opened this issue Nov 17, 2019 · 4 comments
Closed

ENH backend should be classes and not namedtuple #452

edouardoyallon opened this issue Nov 17, 2019 · 4 comments
Labels
1D Issue with 1D scattering code 2D Issue with 2D scattering code 3D Issue with 3D scattering code API Issues in user-facing code enhancement New feature or request
Milestone
0.3.alpha

Comments

@edouardoyallon
Copy link
Collaborator

No description provided.

@edouardoyallon edouardoyallon added enhancement New feature or request API Issues in user-facing code 1D Issue with 1D scattering code 2D Issue with 2D scattering code 3D Issue with 3D scattering code labels Nov 17, 2019
@edouardoyallon edouardoyallon added this to the 0.2.0 milestone Nov 17, 2019
@edouardoyallon edouardoyallon mentioned this issue Nov 17, 2019
Merged
@edouardoyallon
Copy link
Collaborator Author

i handle that tomorrow

@edouardoyallon edouardoyallon removed this from the 0.2.0 milestone Feb 19, 2020
@edouardoyallon edouardoyallon added this to the 0.3.0 milestone Mar 3, 2020
@edouardoyallon
Copy link
Collaborator Author

does it still apply?

@janden
Copy link
Collaborator

janden commented Feb 10, 2021

It's being handled in #631. Feel free to look it over if you have time.

@MuawizChaudhary
Copy link
Collaborator

Seems like with our backends being classes now this solves the issue.

Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1D Issue with 1D scattering code 2D Issue with 2D scattering code 3D Issue with 3D scattering code API Issues in user-facing code enhancement New feature or request
Projects
None yet
Milestone
0.3.alpha
Development

No branches or pull requests
3 participants
@janden @edouardoyallon @MuawizChaudhary