Fix looking up 'XDG_CONFIG_HOME' envvar #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README says that 'era' lookups "$XDG_CONFIG_HOME" as a configuration directory, but it used to just lookup "$HOME/.config". I guess this doesn't make sense. So 'era' first lookups "$XDG_CONFIG_HOME", and if not found the variable, 'era' assumes the value is ~/.config/era now. This behavior probably is familiar in CLI application configurations.
Parent directories of a configuration directory may not exist, and 'mkdir' emits an error such as 'No such file or directory (os error 2)' in such a case. So we add a 'recursive' option to make parent directories too.
|
Thank you! Agreed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README says that 'era' lookups "$XDG_CONFIG_HOME" as a configuration directory, but it used to just lookup "$HOME/.config". I guess this doesn't make sense. So 'era' first lookups "$XDG_CONFIG_HOME", and if not found the variable, 'era' assumes the value is ~/.config/era now. This behavior probably is familiar in CLI application configurations.
And this patch fixes misc trivial stuffs.
Thank you for your cool CLI application.