-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set lookahead in Settings #203
Comments
Disagree. Look ahead should be a standard. If users set it too low not knowing what it is, they shoot thenself in the foot. It also means they must memorize that number or keep it with their wallet seed if they ever import. I think it should not be user configurable. What we really need are deep wallet refractors in hsd. |
did some digging into the rescan behavior and agree with @pinheadmz - a high enough fixed value with a rescan button should fix the problem, or at least give users to keep rescanning until they grabbed all their txs. |
The issue I found with lookahead is that if the values is too high, it actually starts to behave inconsistently. I am guessing that the issue might have to do with size limit of bloom filter, if there is one. The behavior i am noticing is that:
|
These two make sense:
This is a bit surprising:
This is kinda, eh maybe not surprising given the performance hit of generating and scanning for all those keys:
We may find that a lookahead of 1000 takes several seconds when creating a new account, and may cause race conditions when the wallet just isn't ready for API calls yet. I need to try some benchmarks with this value in hsd, but then yeah I think we either need to ditch the internal bloom filter (means rescans will take a lot longer) or refactor it so when a tx is found in a block, the filter is updated and that block is rescanned again: bcoin-org/bcoin@c6859b3 |
User should be able to adjust lookahead so their wallet can support more names/transactions. Powerusers are asking for this as it looks as if stuff is disappearing from their wallets.
I think this should be a number input. You might need to restart the node or at least kick off a rescan -> we could make this automatic or have another button for that.
The text was updated successfully, but these errors were encountered: