Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General todo / clean-up #7

Open
4 tasks
sgtlambda opened this issue Jan 2, 2016 · 2 comments
Open
4 tasks

General todo / clean-up #7

sgtlambda opened this issue Jan 2, 2016 · 2 comments

Comments

@sgtlambda
Copy link

Since I'm interested in this project and I'd like to collaborate to its development, I've made a general to-do list which will give the project a head-start to become a more maintainable plugin for multiple collaborators.

  • Re-format / re-indent code (src/inject/sc-feed-cleaner.js is messy right now and code style consistency will make it easier for multiple maintainers to work on this project at once)
  • Remove external libraries from version tracking (there is a js/jquery folder right now, this might as well be an npm dependency)
  • Remove the .crx file from the repository (this should be a "binary" attached to github releases)

Some lower priority things to consider as well:

  • Seperate the .js source into multiple files and use browserify to bundle them up into a single inject.js (this would work nicely with the idea of installing jquery as an npm module as it would simply allow for var $ = require('jquery');)
@sgtlambda
Copy link
Author

I myself don't have a lot of free time right now but once I do I would be willing to fix the issues in the above list.

@kyranb
Copy link
Owner

kyranb commented Jan 9, 2016

Thanks, I put this together pretty quickly for my own use. All of your proposals to tidy things up sound good. I've got a bit on myself right now, but would be happy to to help implement those suggestions in a few weeks time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants