Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of react in name #4

Open
maratfakhreev opened this issue Aug 2, 2022 · 2 comments
Open

Get rid of react in name #4

maratfakhreev opened this issue Aug 2, 2022 · 2 comments

Comments

@maratfakhreev
Copy link

maratfakhreev commented Aug 2, 2022

Hi @l-mbert and thank you for your plugin, it works perfectly. I have small suggestion for naming improvement, I've used it with Vue 2 + jsx and it has working without any problems. So firstly I was confused about react in the name of plugin and have tried other solutions but then I've checked the code and found that there is not any reference to react engine or deps or smth like this and this plugin could work with any implementation of jsx.
So right now it's a little weird that vue setup uses some react library and maybe would be better to rename/recreate project with name like: vite-plugin-jsx-remove-attributes or vite-plugin-jsx-remove-html-attributes. What do you think?

@jacobbogers
Copy link

Hi @l-mbert , I didn't know this plugin is generic (not specific react)

I want to take the opportunity to thank you for this plugin, superjob!!

@l-mbert
Copy link
Owner

l-mbert commented Apr 11, 2024

Hi there,

Thanks for the kind words! I will tackle this next weekend and check if some upgrades/refactorings need to be made.
Truth be told, I completely forgot about this package. I had the rename in mind but life happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants