Fix CSS for vertical button groups (#869)

Only up to Bootstrap 2.x "btn-group" and "btn-group-vertical" where needed for vertical orientation. Since Bootstrap 3.x only the latter is required. (cherry picked from commit 0fe8b02)
martin-g · Aug 24, 2020 · bc47eb8 · bc47eb8
1 parent 376667e
commit bc47eb8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...re/src/main/java/de/agilecoders/wicket/core/markup/html/bootstrap/button/ButtonGroup.java b/...re/src/main/java/de/agilecoders/wicket/core/markup/html/bootstrap/button/ButtonGroup.java
@@ -81,7 +81,7 @@ protected void onInitialize() {
     protected void onComponentTag(ComponentTag tag) {
         super.onComponentTag(tag);
 
-        Attributes.addClass(tag, orientation.cssClassName(), "btn-group");
+        Attributes.addClass(tag, orientation.cssClassName());
 
         if (!Size.Default.equals(size)) {
             Attributes.addClass(tag, size.cssClassName());

diff --git a/...p-core/src/main/java/de/agilecoders/wicket/core/markup/html/bootstrap/button/Buttons.java b/...p-core/src/main/java/de/agilecoders/wicket/core/markup/html/bootstrap/button/Buttons.java
@@ -79,7 +79,7 @@ public enum Orientation implements ICssClassNameProvider {
 
         @Override
         public String cssClassName() {
-            return equals(Horizontal) ? "" : "btn-group-" + name().toLowerCase();
+            return equals(Horizontal) ? "btn-group" : "btn-group-vertical";
         }
     }