Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap slider #575

Merged
merged 1 commit into from Jan 2, 2016
Merged

Bootstrap slider #575

merged 1 commit into from Jan 2, 2016

Conversation

reiern70-antilia
Copy link

No description provided.

@reiern70
Copy link
Contributor

reiern70 commented Jan 2, 2016

@martin-g

I think I have covered all the things you mentioned on previous PR. Please let me know if anything else needs any action on my side. Thanks again!

Cheers,

Ernesto

martin-g
martin-g reviewed Jan 2, 2016
View reviewed changes
...xtensions/src/main/java/de/agilecoders/wicket/extensions/slider/res/css/bootstrap-slider.css
@@ -0,0 +1,255 @@
/*! =======================================================
VERSION 5.3.7
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that v.6.0.4 is released two days ago.
Do you want the newest version or 5.3.7 is good enough?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just upgraded the files: thanks for spotting that

@martin-g
Copy link
Owner

martin-g commented Jan 2, 2016

Please squash the commits so I can easily merge it to 7.x.
Thanks a lot!

@reiern70
Copy link
Contributor

reiern70 commented Jan 2, 2016

Done! Thanks to you!

martin-g added a commit that referenced this pull request Jan 2, 2016
@martin-g
Merge pull request #575 from reiern70-antilia/bootstrap-slider
108c0bf 
Bootstrap slider
@martin-g martin-g merged commit 108c0bf into martin-g:master Jan 2, 2016
@martin-g
Copy link
Owner

martin-g commented Jan 2, 2016

Up and running at: http://wb-mgrigorov.rhcloud.com/slider !

@reiern70
Copy link
Contributor

reiern70 commented Jan 2, 2016

Thanks!

Sent from my ASUS

-------- Original Message --------
From:Martin Grigorov notifications@github.com
Sent:Sat, 02 Jan 2016 22:53:17 +0100
To:l0rdn1kk0n/wicket-bootstrap wicket-bootstrap@noreply.github.com
Cc:Ernesto Reinaldo Barreiro reiern70@gmail.com
Subject:Re: [wicket-bootstrap] Bootstrap slider (#575)

Up and running at: http://wb-mgrigorov.rhcloud.com/slider !

—
Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reiern70-antilia @reiern70 @martin-g