Move panel's content initialization to the onInitialize method. #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this way when calling Components.hideIfModelIsEmpty upon panel's initialization, there is no hierarchy traversal that tries to get model's object value with the "panelFooter" and "panelBody" property lookups.
martin-g
pushed a commit
that referenced
this pull request
Dec 23, 2019
* Move panel's content initialization to the onInitialize method. * Instead of setting null model, pass empty model - this way when calling Components.hideIfModelIsEmpty upon panel's initialization, there is no hierarchy traversal that tries to get model's object value with the "panelFooter" and "panelBody" property lookups. (cherry picked from commit f6f2903)
martin-g
pushed a commit
that referenced
this pull request
Dec 23, 2019
* Move panel's content initialization to the onInitialize method. * Instead of setting null model, pass empty model - this way when calling Components.hideIfModelIsEmpty upon panel's initialization, there is no hierarchy traversal that tries to get model's object value with the "panelFooter" and "panelBody" property lookups. (cherry picked from commit f6f2903)
|
Thanks, @vrozkovec ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also instead of setting null model, pass empty model - this way when calling
Components.hideIfModelIsEmptyupon panel's initialization, there is no hierarchy traversal that tries to get model's object value with thepanelFooterandpanelBodyproperty lookups.