Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed wrong path in minified css of the BootstrapFileInputField #831

Closed
wants to merge 1 commit into from
Closed

Fixed wrong path in minified css of the BootstrapFileInputField #831

wants to merge 1 commit into from

Conversation

vrozkovec
Copy link
Contributor

@vrozkovec vrozkovec commented Jan 22, 2020 •
edited

../img/loading.gif --> ../res/loading.gif

@coveralls
Copy link

Coverage Status

Coverage remained the same at 47.169% when pulling c86d470 on vrozkovec:wicket-8.x into 053332a on l0rdn1kk0n:wicket-8.x.

@martin-g
Copy link
Owner

I think it would be better to relocate loading.gif in img folder.
This way it will be even easier to copy all resources from upstream.

@vrozkovec
Copy link
Contributor Author

Ok, in that case I'll also update to most recent 4.x version and do another PR

@vrozkovec vrozkovec closed this Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vrozkovec @coveralls @martin-g