Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] stash improvements #10

Open
supersaiyansubtlety opened this issue Apr 3, 2022 · 6 comments
Open

[Request] stash improvements #10

supersaiyansubtlety opened this issue Apr 3, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@supersaiyansubtlety
Copy link

Some improvements:

  1. stash restore gui: less clunky than going into bookmarks folders
  2. store to hard disk or synced storage: lets you attach data and doesn't clutter bookmarks, could make 1) easier
  3. optionally save window and tab states: better compat with other addons, keeps history and potentially scroll position, requires 2) [probably]
@l10nelw
Copy link
Owner

l10nelw commented Nov 26, 2022

I've had to ponder a lot about these ideas, long before your comment. Using bookmarks as storage is meant to be better compatibility as it is transparent and not exclusive to Winger, vs disk/sync storage API which is private to the extension using it. Although the drawbacks with bookmarks are:

  • saving window/tab states in a neat way. I've been attempting this already, by adding state data to bookmark titles. So it's possible, just not so pretty.
  • If there are a lot of bookmarks, it might slow down loading any data for display in the popup (i.e. "stash restore gui" - which I do want someday).

Thank you for your thoughts anyway; it helps bring ideas to front of mind. I just might decide to switch from bookmarks to disk/sync storage, we'll see.

@l10nelw l10nelw added the enhancement New feature or request label Dec 1, 2022
@lediur
Copy link

lediur commented Apr 3, 2023

Hey, started using the extension and the stash feature recently, thanks for your work!

I think managing the stashed windows with the native bookmark manager is decent enough that the work to implement a stash manager might not be worth it to me. On the other hand, I agree with OP that some additional functionality and storing additional tab / window metadata would make the feature even better.

A few things on my wishlist:

  • storing container metadata with the tab. this would help a lot, since otherwise I have to manually go and reopen tabs in containers after unstashing them
  • re-opening tabs in a discarded state. not a huge deal for me, but could help with restore performance or re-opening windows with many many tabs
  • merging multiple windows as bookmark folders. also a nice to have quality of life feature. a workaround involving unstashing, merging, and restashing exists.

Thinking about implementation, I wonder if some kind of "progressive enhancement" with a backing store under the extension's control might be a good stopgap measure? Users can still manage the bookmark folders with the native manager, but the extension could manage some metadata for the folders and tabs in those folders it has knowledge of

@l10nelw
Copy link
Owner

l10nelw commented Oct 8, 2023

Hi, I'm nearly done working on state-stashing and have definitely settled on storing state explicitly in bookmark titles. Can't beat open, transparent and simple.

Let me address your wishlist @lediur:

storing container metadata with the tab.

Absolutely

re-opening tabs in a discarded state

No worries, Winger has always been unstashing discarded tabs.

merging multiple windows as bookmark folders.

Sorry I have to draw the line at bookmark management, need to be careful about scope creep.

@ssssamstrup
Copy link

Seconding a stash gui and buttons for it. 😊

I don't mind bookmarks being "ugly", since it will become more of a fallback/backup than something that's used daily.

Really love your work with the app so far. A lot better than the other solutions I've been using. Sent you a Kofi. 🎊

@l10nelw
Copy link
Owner

l10nelw commented Apr 12, 2024

🎉 Version 2.6.0 adds these new features:

  • Stashing preserves various window and tab properties e.g. private windows, pinned tabs, containers, etc.
  • Stash button for every window row in the panel
  • Stash Tab Here bookmark context menu command

Some longtime wishlist items have finally gone live. 🥂

(Of the requests in this thread, stash listing/restore UI remains.)

@zumm
Copy link

zumm commented Jul 6, 2024

Hi there, i just started using this ext too. Seems very promising, great work! But unstash is clunky af in my opinion. Would be very nice to be able to search stashed windows like normal ones in omnibox and unstash them just by pressing enter (or shift+enter for non-destructive way).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants