Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Move Module Width/Height #62

Open
C0D3-M4513R opened this issue Mar 22, 2021 · 1 comment
Open

[Feature] Move Module Width/Height #62

C0D3-M4513R opened this issue Mar 22, 2021 · 1 comment

Comments

@C0D3-M4513R
Copy link
Contributor

So I noticed, that for every Module, there is a Width and Hight.
Those combos are Static. One Module cannot have multiple Width's and Height's (afaik).
So how about removing the following properties:

overlayURL = http://localhost:24050/Simplistic
overlayWidth = 650
overlayHeight = 150

and replacing them with the following:

overlayName = Simplistic

Everything before and after would still stay the same of course.
One could still reconstruct the needed URL, because we have serverip as a property. The reconstruction should just look similar to this: "http://" + serverip + "/" + overlayName (Please use format Strings in actual code!).

One could then add a config.ini file to each module, where it's height and width are stored. Something along the lines of this:

Width = 650
Height = 150
@l3lackShark
Copy link
Owner

l3lackShark commented Mar 23, 2021

Not sure about the serverip thing as it supports golang formatting (stuff like :24050) static's index.html will see a lot of changes soon so the other parts of this proposal might come as a part of that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants