Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated code #21

Open
C0D3-M4513R opened this issue Mar 11, 2021 · 3 comments
Open

Repeated code #21

C0D3-M4513R opened this issue Mar 11, 2021 · 3 comments

Comments

@C0D3-M4513R
Copy link

A lot of the socket creation and initial data collection is the same across all Counters.
Also a lot of things are repeated in many counters. Maybe it would be good to have commonly used things in a js file, which is included in all counters?

Maybe to the initial socket creation in a common file, and rely on a callback, that will be defined by each counter beforehand?

@C0D3-M4513R C0D3-M4513R changed the title Repeated code. Repeated code Mar 11, 2021
@l3lackShark
Copy link
Owner

The original idea was to have them be self-contained with no extra dependencies. I think zip archives are smart enough to contain only one copy of the same file. So it's not really a big deal I think? Any specific reason you want them to share code?

@C0D3-M4513R
Copy link
Author

C0D3-M4513R commented Mar 11, 2021 via email

@l3lackShark
Copy link
Owner

I see where you're coming from, this might see a change in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants