gameplay.pp.maxThisPlay sometimes broken

[viddie]

My impression of this attribute was that if, from any given point in a play, you SS everything, that will be the pp you get at the end. However, sometimes after breaking combo this value slowly decreases even while playing perfectly. That isn't really the maximum then, or am I misinterpreting this attribute?

Video of this happening (see the pp-bar at the right side at around 0:22): https://www.youtube.com/watch?v=v9cMb2aP_Rw

[l3lackShark]

As explained in the wiki, this value indicates maximum amount of pp possible from a given play (including past hit judgments)
Use pp.fc if you want fc pp at a given acc + remaining hit-objects are assumed as 300's

[viddie]

Yes i get that part. Let's say I get a couple of 100's and misses early on and from there SS the rest of the map. At any given point during the SS part until the end, shouldn't the maxThisPlay be the same value, as you are literally on your way to get the maximum amount of pp you can with the misses/acc loss?

[l3lackShark]

This is probably not the behavior that we are expecting, could be a regression, will look at it

[l3lackShark]

Can I have this replay? @viddie

[viddie]

Sure, here you go https://fu.vi-home.de/f/sLofHRl7 (direct download)

[l3lackShark]

Attempt was made to fix that, test build could be obtained here: https://github.com/l3lackShark/gosumemory/runs/1355174754

[l3lackShark]

Had to redo that job, Here is the build.

[viddie]

That seems to have fixed the issue. I'll repoen this if it does happen to occur again. Thanks!