Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reserved identifier violation #12

Open
elfring opened this issue Mar 18, 2014 · 3 comments
Open

reserved identifier violation #12

elfring opened this issue Mar 18, 2014 · 3 comments

Comments

@elfring
Copy link

elfring commented Mar 18, 2014

Can it be that identifiers like "__SYNC_H__" and "__KICKSTART__KICKSTART_H__" do not fit to the expected naming convention of the C++ language standard?
Would you like to adjust your selection for unique names?

@jkehne
Copy link
Member

jkehne commented Mar 19, 2014

You are right, these do violate the C++ standard. I assume I will fix them eventually, but given this hasn't caused any problems so far, please understand that it won't be my top priority.

@elfring
Copy link
Author

elfring commented Mar 19, 2014

How do you think about to avoid that this software depends on undefined behaviour?

@jkehne
Copy link
Member

jkehne commented Mar 19, 2014

Just to be clear: I do agree with you, and I will fix this eventually. However, I have more important things on my mind right now, so the fix will have to wait.
If you would like to see this fixed more quickly, you are of course welcome to send me a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants