Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of singleton bot within library #18

Closed
Benny- opened this issue Nov 6, 2018 · 2 comments
Closed

Use of singleton bot within library #18

Benny- opened this issue Nov 6, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@Benny-
Copy link
Contributor

Benny- commented Nov 6, 2018

Nyxx is object oriented but different parts of the library all reference the singleton Nyxx bot instance. This leads to problems when creating multiple bots.

For this issue to be resolved, the internal library no longer needs to reference this Nyxx singleton.
@l7ssha l7ssha added the enhancement New feature or request label Nov 6, 2018
@Benny-
Copy link
Contributor Author

Benny- commented Nov 11, 2018

I am willing to take this issue upon myself. My use case requires it.

l7ssha added a commit that referenced this issue Nov 11, 2018
@l7ssha
Removed global nyxx variable #18
ede6355
@l7ssha
Copy link
Member

l7ssha commented Nov 14, 2018

Resolved in ede6355

@l7ssha l7ssha closed this as completed Nov 14, 2018
l7ssha added a commit that referenced this issue Feb 11, 2021
@l7ssha
Removed global nyxx variable #18
90bbe71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Benny- @l7ssha