Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doppler shift calculation sign #64

Closed
2 tasks done
thenorthcore opened this issue Mar 19, 2017 · 0 comments
Closed
2 tasks done

Doppler shift calculation sign #64

thenorthcore opened this issue Mar 19, 2017 · 0 comments
Assignees
@thenorthcore
Labels
bug patch number bump
Milestone
2.0.0

Comments

@thenorthcore
Copy link
Contributor

thenorthcore commented Mar 19, 2017 •
edited
Loading

After looking into #44 after some time, we figured out that the Doppler shift calculation of libpredic has the wrong sign. That effect is not seen by flyby as it appears that the sign there is again moved into the correct direction.

Looking at https://www.la1k.no/wp-content/uploads/2017/03/pass.png the Doppler is negative for an object moving towards the observer and positive after the object passed zenith.

  • Changing sign in calculations
  • Fixing test cases (not touching raw test case data)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thenorthcore thenorthcore

Labels
bug patch number bump
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@thenorthcore @bjorgan