Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight map points from the same structure #4

Open
Luthaf opened this issue Jan 22, 2020 · 2 comments
Open

Highlight map points from the same structure #4

Luthaf opened this issue Jan 22, 2020 · 2 comments
Labels
component-map Issues related to the map component

Comments

@Luthaf
Copy link
Contributor

Luthaf commented Jan 22, 2020

When in atom mode, it would be good to highlight on the map other points pertaining to the same structure as the currently selected atom.

A good way to do that would be to dim / grey out other points, using the same mechanism as #3.

@Luthaf Luthaf added the component-map Issues related to the map component label Jan 22, 2020
@ceriottm
Copy link
Contributor

I think this could/should go hand-in-hand with the highlighting of the "clickable" atoms in the JSMolWidget. When in environment mode, one should see all the environments highlighted in the JSMolWidget, and the corresponding points should be highlighted in the scatter plot - perhaps just made 2x larger, with thicker outline, and brought to front in the z-index.

@Luthaf
Copy link
Contributor Author

Luthaf commented Apr 27, 2020

and brought to front in the z-index.

This is not easy since we are not using HTML to render the graph but WebGL (which is why we are able to render more than 10k points 😄). Instead we would need the same kind of bookeeping infrastructure as for #16 for coloring.

Bringing points on front would require either using a second plotly trace, with the related performance issue when changing the selected point --- this is why we use a small hack to display selected point in 2D mode --- or duplicating the same hack for all highlighted points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-map Issues related to the map component
Projects
None yet
Development

No branches or pull requests

2 participants