Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent users from overwriting non-existent fields #168

Closed
frostedoyster opened this issue Apr 4, 2024 · 0 comments · Fixed by #241
Closed

Prevent users from overwriting non-existent fields #168

frostedoyster opened this issue Apr 4, 2024 · 0 comments · Fixed by #241
Assignees
Labels
Priority: High Critical issues needing immediate attention.

Comments

@frostedoyster
Copy link
Collaborator

Using metatensor-models, it's easy to try to override something in a wrong way.
e.g.

model:
  layernorm: false

when in reality the correct syntax is

model:
  bpnn:
    layernorm: false

In that case, no error is raised, the user thinks they're running without layernorms, but the layernorms are still on

@frostedoyster frostedoyster changed the title Prevent users from non-existent fields Prevent users from overwriting non-existent fields Apr 4, 2024
@PicoCentauri PicoCentauri added the Priority: High Critical issues needing immediate attention. label Jun 3, 2024
@PicoCentauri PicoCentauri self-assigned this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Critical issues needing immediate attention.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants