Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared secret inside the webhook payload has been deprecated #15

Closed
imolein opened this issue Mar 3, 2021 · 2 comments
Closed

Shared secret inside the webhook payload has been deprecated #15

imolein opened this issue Mar 3, 2021 · 2 comments
Assignees

Comments

@imolein
Copy link

imolein commented Mar 3, 2021

Hi,

first, thanks for the plugin!
While I was configuring this, I read the blogpost about the release of Gitea 1.13.0, which says the following:

The Webhook shared secret inside the webhook payload has been deprecated and will be removed in 1.14.0: go-gitea/gitea#11755 please use the secret header that uses an hmac signature to validate the webhook payload.

I thought it is not bad to open an issue about this :)

@pampersrocker
Copy link
Contributor

Thank you for the info. I guess i'll address this as well, when i have time to look at #13 as well.

@pampersrocker pampersrocker self-assigned this Mar 3, 2021
@pampersrocker
Copy link
Contributor

pampersrocker commented Mar 9, 2021

Version v1.4.0 of this plugin now verifies the hmac of the payload instead of comparing the sent secret. v1.4.0 requires buildbot >=3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants