Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responses swallowed when there's an unmarshaling error #106

Open
KirkEasterson opened this issue May 14, 2024 · 1 comment
Open

Responses swallowed when there's an unmarshaling error #106

KirkEasterson opened this issue May 14, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@KirkEasterson
Copy link

Problem: If a response results in an error when being unmarshaled, the response is lost. This makes it impossible to differentiate a 200 response from a 400 response.

This code highlights the issue. If I receive an unmarshaling error, I don't know if the fault was mine or not.

Suggested fix: Wrap the err with content included, or use some structured error that contains more information about this issue.

I can work on this, but how to handle this case should be decided by more than just me.

@KirkEasterson KirkEasterson added bug Something isn't working triage Needs triage labels May 14, 2024
@demeyerthom
Copy link
Member

Hi @KirkEasterson we generate the API based on this repo: https://github.com/commercetools/rmf-codegen. If you feel up to it you can make the changes there.

I will be back next month and can pick this one up then also.

@demeyerthom demeyerthom removed the triage Needs triage label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants