Type change in custom type does not actually change the type in CT

[davidweterings]

Changing a custom type value from f.e. Enum -> String says it succeeded but doesn't actually change it in CommerceTools (formatting here is borked...):

Before

resource "commercetools_type" "custom-order-fields" {
  key = "custom-order-fields"
  name = {
    en = "Custom order fields"
  }

  description = {
    en = "Custom order fields"
  }

  resource_type_ids = ["order"]
  field {
    name = "shipwireServiceLevelCode"

    label = {
      en = "Shipwire service level code"
      nl = "Shipwire service level code"
    }

    type {
      name = "Enum"
      values {
        foo = "bar"
      }
    }
  }

After

resource "commercetools_type" "custom-order-fields" {
  key = "custom-order-fields"
  name = {
    en = "Custom order fields"
  }

  description = {
    en = "Custom order fields"
  }

  resource_type_ids = ["order"]
  field {
    name = "shipwireServiceLevelCode"

    label = {
      en = "Shipwire service level code"
      nl = "Shipwire service level code"
    }

    type {
      name = "String"
    }
  }

TF output:

  ~ commercetools_type.custom-order-fields
      field.1.type.0.name:                           "Enum" => "String"
      field.1.type.0.values.%:                       "7" => "0"
      field.1.type.0.values.economy_international:   "E-INTL" => ""
      field.1.type.0.values.ground_domestic:         "GD" => ""
      field.1.type.0.values.one_day_domestic:        "1D" => ""
      field.1.type.0.values.plus_international:      "PL-INTL" => ""
      field.1.type.0.values.premium_international:   "PM-INTL" => ""
      field.1.type.0.values.standard_international:  "INTL" => ""
      field.1.type.0.values.two_day_domestic:        "2D" => ""

[StarpTech]

This is no bug. According to the code, this is just not implemented. We only respect enum changes not type changes from X to Y. In your example, the actions are zero.

terraform-provider-commercetools/commercetools/resource_type.go

Lines 471 to 508 in 7ae634e

	if enumType, ok := newFieldType.(commercetools.CustomFieldEnumType); ok {
	oldEnumV := oldFieldType["values"].(map[string]interface{})
	for i, enumValue := range enumType.Values {
	if _, ok := oldEnumV[enumValue.Key]; !ok {
	// Key does not appear in old enum values, so we'll add it
	actions = append(
	actions,
	commercetools.TypeAddEnumValueAction{
	FieldName: name,
	Value: &enumType.Values[i],
	})
	}
	}
	// Action: changeEnumValueOrder
	// TODO: Change the order of EnumValues: https://docs.commercetools.com/http-api-projects-types.html#change-the-order-of-fielddefinitions
	} else if enumType, ok := newFieldType.(commercetools.CustomFieldLocalizedEnumType); ok {
	oldEnumV := oldFieldType["localized_value"].([]interface{})
	oldEnumKeys := make(map[string]map[string]interface{}, len(oldEnumV))
	for _, value := range oldEnumV {
	v := value.(map[string]interface{})
	oldEnumKeys[v["key"].(string)] = v
	}
	for i, enumValue := range enumType.Values {
	if _, ok := oldEnumKeys[enumValue.Key]; !ok {
	// Key does not appear in old enum values, so we'll add it
	actions = append(
	actions,
	commercetools.TypeAddLocalizedEnumValueAction{
	FieldName: name,
	Value: &enumType.Values[i],
	})
	}
	}

Besides that, it's important no note that in commercetools, custom field definitions(identified by its name) are "singletons". As soon as a field definition is used by more than one custom type it's not possible to change the type of the field without changing the name.

Therefore in that scenario, it's always required to create a new field if we want to update the type.

This could be tricky to check. WDYT?

[mvantellingen]

Commercetools doesn't support changing the type of a field. I think we now show an error in terraform that you need to delete the field and add it again. We need to check this

[mvantellingen]

Just checked; we are raising an error