Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for relative threshold #58

Open
billbrod opened this issue Aug 17, 2020 · 0 comments
Open

Add support for relative threshold #58

billbrod opened this issue Aug 17, 2020 · 0 comments
Labels
enhancement New feature or request
Projects

Comments

@billbrod
Copy link
Member

For Synthesis (and its subclasses), we have two stopping criteria: either you reach max_iter or your (absolute) loss decreases by less than loss_thresh over the past loss_change_iter iterations. But this is an absolute number, which is going to differ wildly depending on the magnitude of your loss.

Would like to add support for a relative threshold, rel_loss_thresh, which checks whether (absolute) loss has decreased by rel_loss_thresh * loss_prev over the past loss_change_iter iterations. On each iteration check if loss < loss - rel_loss_thresh * loss_prev and, if so, update loss_prev = loss. Keep going until there have been loss_change_iter iterations without that, and then break.

This would go into Synthesis._check_for_stabilization, and would need to do a similar check with coarse_to_fine

@billbrod billbrod added the enhancement New feature or request label Aug 17, 2020
@billbrod billbrod added this to Medium term milestones in Roadmap Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Roadmap
  
Medium term milestones
Development

No branches or pull requests

1 participant