Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend metrics with new Datasets #4

Closed
ldb opened this issue Jan 22, 2021 · 4 comments · Fixed by #7
Closed

Extend metrics with new Datasets #4

ldb opened this issue Jan 22, 2021 · 4 comments · Fixed by #7

Comments

@ldb
Copy link
Contributor

ldb commented Jan 22, 2021

Hello,

so far, the exporter is only using the httpRequests1mGroups and httpRequests1dByColoGroups, the latter of which is being sunset on March 1, 2021.

I'd like to suggest to extend the available metrics by also making use of the following Datasets:

  • firewallEventsAdaptiveByTimeGroups
  • ipFlows1mAttacksGroups
  • synAvgPps1mGroups

I would also be happy to implement these myself and open a PR, but wanted to check interest with you first.
@martinhaus
Copy link
Member

Hey @ldb, please feel free to implement any of the datasets you mentioned and make a PR

@martinhaus
Copy link
Member

The httpRequests1dByColoGroups will be deprecated in the 0.0.4 release.
@ldb did you have a chance to work on the other datasets?

@ldb
Copy link
Contributor Author

ldb commented Mar 11, 2021

Hey @martinhaus, no, not yet.

@ldb ldb mentioned this issue Mar 12, 2021
Merged
@ldb
Copy link
Contributor Author

ldb commented May 3, 2021

@martinhaus Maybe you missed it, but I opened another PR for this same issue here: #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: Add basic firewall events metrics ldb/cloudflare-exporter
2 participants
@ldb @martinhaus