Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings and errors from go lang linter #54

Closed
tomas-balaz opened this issue Nov 30, 2021 · 0 comments · Fixed by #56
Closed

Fix warnings and errors from go lang linter #54

tomas-balaz opened this issue Nov 30, 2021 · 0 comments · Fixed by #56
Assignees
@tomas-balaz

Comments

@tomas-balaz
Copy link
Contributor

go lang linter detected these issues:

  • Error: zoneRequestUncached is unused (deadcode)
  • Error: zoneRequestSSLUnencrypted is unused (deadcode)
  • Error: zoneBandwidthUncached is unused (deadcode)
  • Error: zoneBandwidthSSLUnencrypted is unused (deadcode)
  • Error: zonePageviewsSearchEngines is unused (deadcode)
  • Error: var-naming: struct field CpuTimeP50 should be CPUTimeP50 (revive)
  • Error: var-naming: struct field CpuTimeP75 should be CPUTimeP75 (revive)
  • Error: var-naming: struct field CpuTimeP99 should be CPUTimeP99 (revive)
  • Error: var-naming: struct field CpuTimeP999 should be CPUTimeP999 (revive)
  • Error: var-naming: var workerCpuTime should be workerCPUTime (revive)
  • Error: SA5008: invalid JSON field name "requests\t" (staticcheck)

Fix these errors to pass the pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomas-balaz tomas-balaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix warnings and errors from go lang linter tomas-balaz/cloudflare-exporter
1 participant
@tomas-balaz