This repository has been archived by the owner on Sep 22, 2023. It is now read-only.
Rename kernel to (compute)session #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* aioresponses 0.6.2 uses deepcopy which requires all custom objects passed to aiohttp request arguments to be picklable.
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
+ Coverage 43.25% 43.61% +0.36%
==========================================
Files 51 52 +1
Lines 5216 5278 +62
==========================================
+ Hits 2256 2302 +46
- Misses 2960 2976 +16
Continue to review full report at Codecov.
|
* Negotiation fallbacks to the configured API version if fails.
achimnol
added a commit
that referenced
this pull request
Jan 12, 2020
* Fix missing version-aware naming in cli.app * Tested with both "api" mode (against local dev) and "session" mode (against 19.09 cloud) by running CLI hello-world and Jupyter app service. * Drop compat.token_hex and compat.token_bytes to use the Python 3.6+ stdlib secrets module.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer confusion in docs.
We introduce the API version v5, where
kernelis renamed tosessionin all places.This PR does the followings:
ai.backend.client.funcpackageai.backend.client.sessioncontains the API session base classes with sync/async implementations whileai.backend.client.func.sessioncontains the ComputeSession function class.api_versionattribute) to branch out old "kernel"-prefixed APIs and "session"-prefixed APIs.APIVersionWarningto suggest package upgrade.