Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement snapshot creation policy #48

Open
jopemachine opened this issue Oct 17, 2023 · 0 comments
Open

Implement snapshot creation policy #48

jopemachine opened this issue Oct 17, 2023 · 0 comments
Labels
feature New feature or request good first issue Good for newcomers improvement snapshot

Comments

@jopemachine
Copy link
Member

jopemachine commented Oct 17, 2023

The current implementation of creating a snapshot is only executed after handle_committed_normal_entry.

I think there could be better ways.

For example, we can implement the following policies:

Create a snapshot when the size of the FSM exceeds a specific threshold.
Generate a snapshot when the number of log entries surpasses a certain count.

Note: snapshot contains several metadata configuring the cluster, so wrong implementation of this would break the consistency of the raft loop.

@jopemachine jopemachine added feature New feature or request improvement labels Oct 17, 2023
@jopemachine jopemachine linked a pull request Oct 17, 2023 that will close this issue
@jopemachine jopemachine changed the title Improve snapshot creating handling logic Implement snapshot creation policy Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers improvement snapshot
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant