Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line numbers are clipped on Firefox #62

Closed
captn3m0 opened this issue Jun 23, 2021 · 2 comments
Closed

Line numbers are clipped on Firefox #62

captn3m0 opened this issue Jun 23, 2021 · 2 comments

Comments

@captn3m0
Copy link
Contributor

Screenshot for https://nn.labml.ai/cfr/index.html#section-0

image

Using Firefox 89.0.1 (64-bit) on Linux

Removing the width from .lineno seems to fix it:

span.lineno {
    width: 20px;
}

Doesn't seem to have an impact on Chrome.

captn3m0 added a commit to captn3m0/annotated_deep_learning_paper_implementations that referenced this issue Jun 23, 2021
@vpj
Copy link
Member

vpj commented Jun 23, 2021

A better solution is to increase the width to something like 25px. Can you try and see if it works on firefox? Because if we remove the width there will be an alignment problem because the line numbers will have different number of digits and hence different widths.

Can include something like white-space: nowrap to make sure it doesn't get split into two lines.

@captn3m0
Copy link
Contributor Author

white-space: nowrap fixes it as well, I'll update the PR.

@vpj vpj closed this as completed in 5f46669 Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants