Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use extension to choose the compression format and check if file contains fastq data #52

Closed
natir opened this issue Feb 27, 2017 · 2 comments
Closed

Don't use extension to choose the compression format and check if file contains fastq data #52

natir opened this issue Feb 27, 2017 · 2 comments
Assignees
@natir
Milestone
0.3

Comments

@natir
Copy link
Member

natir commented Feb 27, 2017 •
edited
Loading

Actualy we use the last extension in filename to choose the compression format, we can replace it by read the magic number.

  • gz : 1f 8b (2 bytes)
  • bz2 : 'BZ' (16 bytes)
  • xz : { 0xFD, '7', 'z', 'X', 'Z', 0x00 } (6 bytes)

For check if file is fastq just read the first character of first 4 lines -> @, [a-Z], +, [.]
@natir natir mentioned this issue Feb 27, 2017
Closed
@natir natir self-assigned this Feb 27, 2017
@natir natir added this to the 0.3 milestone Feb 27, 2017
@dridk dridk changed the title Didn't use extension to choice the compression format Don't use extension to choice the compression format Feb 27, 2017
@dridk dridk changed the title Don't use extension to choice the compression format Don't use extension to choose the compression format Feb 27, 2017
@natir natir changed the title Don't use extension to choose the compression format Don't use extension to choose the compression format and check file is containt fastq Feb 27, 2017
@natir natir changed the title Don't use extension to choose the compression format and check file is containt fastq Don't use extension to choose the compression format and check file is containt fastq data Feb 27, 2017
@natir natir changed the title Don't use extension to choose the compression format and check file is containt fastq data Don't use extension to choose the compression format and check if file containt fastq data Feb 27, 2017
@dridk dridk changed the title Don't use extension to choose the compression format and check if file containt fastq data Don't use extension to choose the compression format and check if file contains fastq data Feb 27, 2017
@dridk
Copy link
Member

dridk commented Feb 27, 2017

This issue is related to #51 too. Could you manage this one too ?

@natir natir closed this as completed Feb 27, 2017
@dridk
Copy link
Member

dridk commented Mar 2, 2017

Fixed Crash when you open xz file : 3d0cf56
Need to release a 0.2.2 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@natir natir

Labels
None yet
Projects
None yet
Milestone
0.3
Development

No branches or pull requests
2 participants
@dridk @natir