Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest gommon commit has broken echo #1346

Closed
3 tasks done
cousinbenson opened this issue Jun 4, 2019 · 1 comment
Closed
3 tasks done

latest gommon commit has broken echo #1346

cousinbenson opened this issue Jun 4, 2019 · 1 comment
Assignees
Labels

Comments

@cousinbenson
Copy link
Contributor

cousinbenson commented Jun 4, 2019

/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/
/ / / / / / / / / / / / / / / / / /

Please use forum https://forum.labstack.com to ask questions!

/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/_/
/ / / / / / / / / / / / / / / / / /

Issue Description

it seems the latest commit to gommon has broken echo

Checklist

  • Dependencies installed
  • No typos
  • Searched existing issues and docs

Expected behaviour

server spins up

Actual behaviour

# github.com/labstack/echo /go/src/github.com/labstack/echo/echo.go:297:9: cannot use "github.com/labstack/gommon/log".New("echo") (type *"github.com/labstack/gommon/log".Logger) as type Logger in field value: *"github.com/labstack/gommon/log".Logger does not implement Logger (wrong type for Level method) have Level() uint8 want Level() "github.com/labstack/gommon/log".Lvl /go/src/github.com/labstack/echo/echo.go:305:19: cannot use "github.com/labstack/gommon/log".ERROR (type uint8) as type "github.com/labstack/gommon/log".Lvl in argument to e.Logger.SetLevel /go/src/github.com/labstack/echo/echo.go:687:20: cannot use "github.com/labstack/gommon/log".DEBUG (type uint8) as type "github.com/labstack/gommon/log".Lvl in argument to e.Logger.SetLevel

Steps to reproduce

pull latest gommon master

Working code to debug

package main

func main() {
    srv := echo.New()
    _ = srv
}

Version/commit

@vishr
Copy link
Member

vishr commented Jun 8, 2019

Fixed in latest

@vishr vishr closed this as completed Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants