Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Go 1.15 to CI #1683

Merged
merged 2 commits into from Nov 20, 2020
Merged

Conversation

asahasrabuddhe
Copy link
Contributor

Since Go 1.15 is released, we should add support for testing against that version. Also, since Go 1.12 is not longer supported, it is removed from the matrix.

@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #1683 (fdbcc2f) into master (7a90304) will increase coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1683      +/-   ##
==========================================
+ Coverage   84.35%   84.72%   +0.37%     
==========================================
  Files          28       29       +1     
  Lines        1911     1938      +27     
==========================================
+ Hits         1612     1642      +30     
+ Misses        189      188       -1     
+ Partials      110      108       -2     
Impacted Files Coverage Δ
middleware/decompress.go 94.73% <0.00%> (ø)
middleware/cors.go 85.52% <0.00%> (+7.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a90304...fdbcc2f. Read the comment docs.

@lammel
Copy link
Contributor

lammel commented Nov 20, 2020

Thanks @asahasrabuddhe for adding go1.15.
I'd like to keep go 1.12 just for a few months longer as not all developers have moved yet probably.

Please adjust, I'll merge then.

@asahasrabuddhe
Copy link
Contributor Author

Thanks @asahasrabuddhe for adding go1.15.
I'd like to keep go 1.12 just for a few months longer as not all developers have moved yet probably.

Please adjust, I'll merge then.

Done

@lammel lammel changed the title Add support for Go 1.15 & Drop support for Go 1.12 Add support for Go 1.15 to CI Nov 20, 2020
@lammel lammel merged commit ad3be08 into labstack:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants