Do not handle special trailing slash case for partial prefix #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1741 +/- ##
=======================================
Coverage 86.75% 86.75%
=======================================
Files 29 29
Lines 2069 2069
=======================================
Hits 1795 1795
Misses 175 175
Partials 99 99
Continue to review full report at Codecov.
|
lammel
reviewed
Jan 2, 2021
stffabi
force-pushed
the
fix-any-prefix
branch
from
fd0ecf4
to
0d976f7
Compare
Only handle the special trailing slash case if the whole prefix matches. Otherwise we might be using a completely wrong route, e.g. /users/* for the path /users_prefix/ where the route is only a partial prefix of the requested path.
|
Thanks for your contribution @stffabi! |
|
@lammel awesome thank you very much for merging this in. Are there any plans for a new release in the near future? |
|
Yes, a new release is expected within the next days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only handle the special trailing slash case if the whole prefix
matches. Otherwise we might be using a completely wrong
route, e.g. /users/* for the path /users_prefix/ where
the route is only a partial prefix of the requested path.
Fixes #1739