DefaultHTTPErrorHandler does not log

[linglingqi007]

Issue Description

DefaultHTTPErrorHandler does not record the err returned by handler

Checklist

• Dependencies installed
• No typos
• Searched existing issues and docs

Expected behaviour

Actual behaviour

No errors logged

Steps to reproduce

Returns an error in the handler

Working code to debug

package main

func main() {
    e := echo.New()
    e.GET("/", func(ctx echo.Context) error {
        return fmt.Errorf("hello")
    })
    e.Start(":7123")
}

Version/commit

v4.11.4

[aldas]

DefaultHTTPErrorHandler is not meant to log errors. It is meant to send error responses. It logs errors only for cases when writing the response failed. To log errors use:

• Older logger middleware: https://github.com/labstack/echo/blob/master/middleware/logger.go
• Newer request logger https://github.com/labstack/echo/blob/master/middleware/request_logger.go

[linglingqi007]

DefaultHTTPErrorHandler is not meant to log errors. It is meant to send error responses. It logs errors only for cases when writing the response failed. To log errors use:

• Older logger middleware: https://github.com/labstack/echo/blob/master/middleware/logger.go
• Newer request logger https://github.com/labstack/echo/blob/master/middleware/request_logger.go

The feeling of documentation can be misleading.

The other part of the tutorial documents both the ERR returned by the handler and the ERR that ultimately sends the response.

But it's actually as you said，It logs errors only for cases when writing the response failed.

[aldas]

I will take a look at Echo docs and see if I can improve things.

Notes for other readers in future:

• Echo error handler docs are found here https://echo.labstack.com/docs/error-handling#custom-http-error-handler
• If anyone wants to improve and/or clarify things in docs, the repo is here https://github.com/labstack/echox