Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Build on MacOSX #6

Open
xfleckx opened this issue Aug 4, 2016 · 14 comments
Open

Test Build on MacOSX #6

xfleckx opened this issue Aug 4, 2016 · 14 comments

Comments

@xfleckx
Copy link
Collaborator

xfleckx commented Aug 4, 2016

I'm would appreciate that someone on a Mac could test building the DemoScene.

Please build for all available target plattforms on Mac so we make sure for which cases it will work.

@xfleckx xfleckx added this to the stable version 1.10 milestone Aug 4, 2016
@Argzero
Copy link
Collaborator

Argzero commented Mar 6, 2019

I'll do it if you don't mind

@xfleckx
Copy link
Collaborator Author

xfleckx commented Mar 9, 2019

Thx, go for it. :)

@Argzero
Copy link
Collaborator

Argzero commented Nov 4, 2019

Attaching a video of build on OSX 64-bit

@Argzero
Copy link
Collaborator

Argzero commented Nov 4, 2019

Built the Demo Inlet Scene. Made some modifications to suit my specific stream.
https://youtu.be/B9uFhEEFlU8

@Argzero
Copy link
Collaborator

Argzero commented Nov 8, 2019

Note: I added some of the changes I thought others might benefit from to my recent pull request. Please let me know if there are any concerns!

@Argzero
Copy link
Collaborator

Argzero commented Nov 8, 2019

I did notice that occasionally, on OSX at least, when my code recompiles while playing, this sometimes causes Unity itself to crash.

Seeing as this is a bug with the editor and not the build this creates a separate issue that needs resolution. My guess is its a memory management issue since Unity gives no meaningful commentary on crashing. I can check to see if there's a log file if you need more information but I'm going to make a separate issue on this.

@xfleckx
Copy link
Collaborator Author

xfleckx commented Nov 9, 2019

Big thx, @Argzero ! Unfortunately I'm not able to maintain the project more regularly. Are you interested in becoming a maintainer of the project?

@jfrey-xx
Copy link
Collaborator

jfrey-xx commented Nov 9, 2019

Hello, it might not be the best place to discuss that, but if you are looking for help maintaining the project, I bet there are several users that could give a hand -- for instance I'd be willing to help clean out the bug tracker :)

On the research side I have been using LSL4Unity together with @jelenaLis , updating our branch with some fixes / improvements here and there. And now within Ullo ( http://ullo-world.fr/website/en ) we are also using it extensively for various developments, so we might have ressources there as well to contribute. If you consider opening up the dev, it could be an opportunity to discuss some functionalities that LSL4Unity could provide beyond LSL itself -- for example in my tiny slightly oldest and finally ditched https://github.com/conphyture/LSL2Unity/ I had the need for normalizing on the fly inputs which boundaries were unknown, I don't know up to which point it could be interesting for others.

Finally, beside the pure dev there is also the documentation, @jelenaLis wrote detailed tutorials about LSL4Unity, we could update it and put it in a wiki section -- or even run a dedicated github page, depending on the ambitions ^^

Whatever the future directions, this project became an important piece of software for many people interested in physio, I just hope it will keep up with the new software :)

@cboulay
Copy link
Collaborator

cboulay commented Nov 9, 2019

Hi all,

@xfleckx , if you would like to transfer ownership of the repo to the labstreaminglayer group (via transferring to me first), I can then administer access rights. Of course I'll add you right away and I can add other contributors who are invested in it.

That being said, I would like to see the LSL.cs updates and library-loading friendliness here get back-ported to liblsl-Csharp and have LSL4Unity be reliant on that, rather than have the two diverging versions of LSL.cs we have now.

@xfleckx
Copy link
Collaborator Author

xfleckx commented Nov 9, 2019

@cboulay I transfered the ownership to you. Thx for the takeover.

@jfrey-xx
Copy link
Collaborator

jfrey-xx commented Nov 9, 2019

...and thanks for opening the repo, I'll have a look at what I have so far on my side, cleaning up the code in the process!

@Argzero
Copy link
Collaborator

Argzero commented Nov 10, 2019

I would like to be included in this access so that I may continue to contribute.

@cboulay
Copy link
Collaborator

cboulay commented Nov 10, 2019

Sure thing.

Even though we have more people with write access now, I would still prefer that any changes to the master branch come in the form of pull requests. However you should feel free to use this repository for your feature branches while preparing a PR. It makes it slightly easier for the rest of us to test it out.

I usually don't mind pushing directly to master if you're patching a bug you created in a recent merge.

@Argzero
Copy link
Collaborator

Argzero commented Nov 10, 2019

Sure thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants