Add configuration option to hide Window Decorations

[joshuataylor]

tldr: I prefer to not show Window Decorations at all.

It would be great to add a config option that would allow users to hide window decorations, something like this:

<core>
  <decoration>server</decoration>
  <show_decorations>false</show_decorations>
</core>

Server side decorations would need to be enabled for this to work, I think?

In view.c, there is this code block:

void
view_set_decorations(struct view *view, bool decorations)
{
	assert(view);
	if (view->ssd_enabled != decorations && !view->fullscreen) {
		/*
		 * Set view->ssd_enabled first since it is referenced
		 * within the call tree of ssd_create()
		 */
		view->ssd_enabled = decorations;
		if (decorations && rc.show_decorations != true) {
			decorate(view);
		} else {
			undecorate(view);
		}
		view_apply_special_geometry(view);
	}
}

Here we could check if the config option has been set, then only decorate if it hasn't. By default it will decorate.

Right now I just have that codeblock commented out and use that. :-)

I'd be happy to implement this feature if this is something that is in scope of labwc and others agree.

Ideally, the initial implementation would consist of the following:

1. Add a configuration option to core to toggle window decorations
2. Add the check to that function (I think that's the best spot for it?)

Would love to get others thoughts on this :-)

[Consolatis]

I don't see an issue with providing that option, we could potentially just add a new value for the existing decoration flag, e.g. something like

<decorations>none</decorations>

We would need to explain in the docs that this setting may not prevent applications to still use client side decorations even though we told them that we prefer server side ones.

We should likely also allow users to disable decorations by default via none but still toggle them manually via the ToggleDecorations action.

Regarding the correct place to check, that one could do it. I think we also have a check somewhere else which decides on the initial state of view->ssd_enabled, likely split into a xwayland and a xdg one. Would need to look into that.

[johanmalm]

I prefer to stay consistent with Openbox 3.6 unless there is good reason to deviate.

Consider

<applications>
  <application class="*">
    <decor>no</decor>
  </application>
</applications>

With s/class/app_id/ ?

Ref: http://openbox.org/wiki/Help:Applications

The following is also related:

<theme>
  <keepBorder>yes</keepBorder>
</theme>

We held off on implementing <applications> so far, but I think it feels right to go for it at some point.
See this comment for reference: #433 (comment)

[hype3]

Is there any timeframe when this will be implented? Will it also be possible to use thicker borders if I want?

[joshuataylor]

Hi!

Been super busy with some personal stuff, but this issue is just for tracking hiding the Window Decorations, so it goes from this:

to this:

[Consolatis]

Regarding the screenshots above, this seems more like the issue we currently have with the default settings for the SSD decorations for Qt applications. E.g.

• Can't hide window decorations through qt5 #594

Edit:
Moved the keepBorder request to its own issue and marked the discussion about it as offtopic in this thread.

• Openbox keepBorder feature #813

Edit 2:

• Application policy framework #900

[Consolatis]

This should now be possible with something like this:

<windowRules>
    <windowRule identifier="*" serverDecoration="no" />
</windowRules>

Please comment if it isn't working or there are issues with the new feature.