Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxqt #941

Closed
6 tasks done
johanmalm opened this issue May 27, 2023 · 10 comments
Closed
6 tasks done

lxqt #941

johanmalm opened this issue May 27, 2023 · 10 comments

Comments

@johanmalm
Copy link
Collaborator

johanmalm commented May 27, 2023

Things to fix in general:

In support of lxqt-panel

In support of lxqt-notificationd

  • Window-rule property allowFocusRequest in support of <windowRule identifier="lxqt-notificationd" skipTaskbar="yes" skipWindowSwitcher="yes" allowFocusRequst="no">
@stefonarch
Copy link
Contributor

For notifications some kind of <windowRule identifier="lxqt-notificationd" skipTaskbar="yes" skipWindowSwitcher="yes" nofocus="yes"> rule would be needed.

@stefonarch
Copy link
Contributor

In support of lxqt-panel

Just started using gaps and the panel is affected by it, so a gap="no" maybe needed.

@Consolatis
Copy link
Member

That might somewhat complicate the codebase. Just thinking out loud, maybe we could instead add an optional argument to MoveToEdge which ignores the gap. I am not sure which variant is less disruptive.

@stefonarch
Copy link
Contributor

stefonarch commented May 30, 2023

Sure, on the long run the panel will hopefully have the necessary code when layer-shell-qt becomes usable.
Just noticed that using "region="top" gives no gap, the only downside is that the config window follows this rule too. Didn't fiddle with "bottom" though. Nope, had gap=0 in rc.xml

@johanmalm
Copy link
Collaborator Author

In support of lxqt-panel

Just started using gaps and the panel is affected by it, so a gap="no" maybe needed.

Yes, I had noticed the regions/gap interaction. Also, regions currently only take a % argument, so not quite right atm.
I envisaged a simple MoveTo (which doesn't take into account gaps) as suggested in Original Post. Thoughts?

@stefonarch
Copy link
Contributor

This sounds good. Using "regions" has also the downside that it affects the config window.

@stefonarch
Copy link
Contributor

Some checkboxes can be ticked. The 60px rule could stay as it doesn't matter anymore, a bottom panel can be placed with <action name="MoveTo" x="0" y="x"/> with x = screen height - panel height, although all popups open at screen border so it's anyway not really usable.

@stefonarch
Copy link
Contributor

Hide always-on-top layer when running an application in full-screen.

Nonetheless I knew that for a panel "layer-bottom+exclusive zone" is the best combination I never tested it until today. It works perfectly, although 2 applications are on the bottom layer (panel and pcmanf-qt's desktop) the panel stays above the desktop always as the latter respects "margin-top".

So "nofocus" rule is the last missing piece: #1057

@stefonarch
Copy link
Contributor

stefonarch commented Mar 15, 2024

In support of lxqt-notificationd

This can be removed as in LXQt 2.0 all components which need layershell have it built it.

Remove 60px hard-coded min-height

I don't remember exactly but with margin= it was no issue anymore.

Hide always-on-top layer when running an application in full-screen.

lxqt-panel 2.0 uses mLayerWindow->setLayer(LayerShellQt::Window::LayerTop); and using F11 on other applications or fullscreen youtube video the panel is hidden, so this looks solved somewhere.
Thanks a lot for the given support of LXQt 1.x . !

@johanmalm
Copy link
Collaborator Author

Thanks @stefonarch
Have updated OP. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants