Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined names in TextThought.delete_surroundings() #2

Open
takluyver opened this issue Sep 4, 2012 · 0 comments
Open

Undefined names in TextThought.delete_surroundings() #2

takluyver opened this issue Sep 4, 2012 · 0 comments
Labels

Comments

@takluyver
Copy link
Member

Pyflakes points out that this method refers to variables old and local_bytes which are never defined. It's not clear what they should be, although perhaps old should be orig (which is defined).

These were already missing when TextThought was refactored 4 years ago (185c2c4). I think this method is only called when using advanced input methods, like those for entering Chinese, so I don't know how to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant