Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring this app #5

Closed
ekmas opened this issue Aug 10, 2023 · 11 comments
Closed

Refactoring this app #5

ekmas opened this issue Aug 10, 2023 · 11 comments

Comments

@ekmas
Copy link

ekmas commented Aug 10, 2023

Hi, I like this project a lot. The main issue with why the app is so laggy is that you literally added whole libraries to this app. I think the better approach would be to use npm to install all these libraries and then use a module bundler like webpack or rollup.

I can help you with that if you're interested :D

@LabyStudio
Copy link
Owner

The reason I refused to use such tools is that I never wanted to achieve anything with this project.
For me, it was just a way to pass the time during school so I had something to jump around when I was bored.

I also wanted to understand and document all the important features of the Minecraft rendering engine.
So the focus for me is more on the code and being able to debug it without issues.
Compiling it into a big garbage only makes it worse to debug it in the browser.

@LabyStudio
Copy link
Owner

But of course it only makes sense to refactor it in order to implement it correctly.
But to be honest, I would just rewrite it right away if I had the time 😅

@CrazyH2
Copy link

CrazyH2 commented Jan 27, 2024

But of course it only makes sense to refactor it in order to implement it correctly.

But to be honest, I would just rewrite it right away if I had the time 😅

@LabyStudio

Hi, I just wanted to say that Kleat has improved the fps a lot. It was bad due to the font rendering as it was rendering every single character from a image file rather that using a normal font and importing that. Heres the github commit: Kleeat@d8ddcc7

@bitlogist
Copy link

Thank you, @CrazyH2 that information was very useful. Thank you, @LabyStudio for making the best repo I've ever seen in my life. I just think it would be nice to save changes made by players in the default multiplayer server.

@ekmas ekmas closed this as completed Feb 21, 2024
@ekmas ekmas closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2024
@CrazyH2
Copy link

CrazyH2 commented Feb 22, 2024

Thank you, @CrazyH2 that information was very useful. Thank you, @LabyStudio for making the best repo I've ever seen in my life. I just think it would be nice to save changes made by players in the default multiplayer server.

Your welcome. I am currently improving this project a bunch, and have made it so you can join any cracked server and build and place blocks with the help of someone else.

@bitlogist
Copy link

Thank you, @CrazyH2 that information was very useful. Thank you, @LabyStudio for making the best repo I've ever seen in my life. I just think it would be nice to save changes made by players in the default multiplayer server.

Your welcome. I am currently improving this project a bunch, and have made it so you can join any cracked server and build and place blocks with the help of someone else.

I am working on a survival mode because it would be so fun to play survival in the browser.

@CrazyH2
Copy link

CrazyH2 commented Feb 29, 2024

Thank you, @CrazyH2 that information was very useful. Thank you, @LabyStudio for making the best repo I've ever seen in my life. I just think it would be nice to save changes made by players in the default multiplayer server.

Your welcome. I am currently improving this project a bunch, and have made it so you can join any cracked server and build and place blocks with the help of someone else.

I am working on a survival mode because it would be so fun to play survival in the browser.

@bitlogist Do you want to join up because i am currently working on it to.

I have added a lot

@CrazyH2
Copy link

CrazyH2 commented Mar 6, 2024

Thank you, @CrazyH2 that information was very useful. Thank you, @LabyStudio for making the best repo I've ever seen in my life. I just think it would be nice to save changes made by players in the default multiplayer server.

Your welcome. I am currently improving this project a bunch, and have made it so you can join any cracked server and build and place blocks with the help of someone else.

I am working on a survival mode because it would be so fun to play survival in the browser.

@bitlogist, How is it going?

@bitlogist
Copy link

It's going well. I managed to render tools (an iron pickaxe) by making them special blocks.

@bitlogist
Copy link

bitlogist commented Mar 14, 2024

My friend, @intfract, has a repo with these changes.

@CrazyH2
Copy link

CrazyH2 commented Mar 17, 2024

My friend, @intfract, has a repo with these changes.

Ok, thanks I will take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants